CMake: Create linux appimage #11182
Merged
CMake: Create linux appimage #11182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-linux-appimage
branch
3 times, most recently
from
e6e7064
to
46bb98a
Compare
|
So is this draft then. You're just testing, don't merge? |
HTRamsey
force-pushed
the
dev-linux-appimage
branch
from
46bb98a
to
7a29006
Compare
|
Good question, I cleaned it up a little just now but left some of the commented out stuff in the .cmake just in case. It seems to work as-is right now. |
|
OK, I'll merge then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure linuxdeployqt is needed anymore because of the built in qt_generate_deploy_qml_app_script, but let's try it out anyway. I can only test via CI because the AppImageToolkit/linuxdeployqt guys are hostile about supporting newer os. I believe this might be the better option
Edit: I have several different methods commented out to try in the cmake file.